Consistently use constant-time comparison of password hashes instead of bare password strings #7455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
force-pushed
the
consistent_node_auth
branch
from
2a52bbf
to
0848136
Compare
As per golang/go#47001 even subtle.ConstantTimeCompare should never be used with variable-length inputs, as it will return 0 if the lengths do not match. Switch to consistently using constant-time comparisons of hashes for password checks to avoid any possible side-channel leaks that could be combined with other vectors to discover password lengths. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
consistent_node_auth
branch
from
0848136
to
840ddeb
Compare
brandond
commented
May 8, 2023
| @@ -60,14 +60,6 @@ func Read(file string) (*Passwd, error) { | |||
| return result, nil | |||
| } | |||
|
|
|||
| func (p *Passwd) Check(name, pass string) (matches bool, exists bool) { | |||
There was a problem hiding this comment.
Note: this function was not used anywhere in the codebase.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7455 +/- ##
===========================================
+ Coverage 19.48% 47.53% +28.04%
===========================================
Files 81 139 +58
Lines 5497 14254 +8757
===========================================
+ Hits 1071 6775 +5704
- Misses 4204 6403 +2199
- Partials 222 1076 +854
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
briandowns
approved these changes
May 9, 2023
johnatasr
approved these changes
May 9, 2023
rbrtbnfgl
approved these changes
May 9, 2023
This was referenced May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Consistently use constant-time comparison of password hashes
As per golang/go#47001 even subtle.ConstantTimeCompare should never be used with variable-length inputs, as it will return 0 if the lengths do not match. Switch to consistently using constant-time comparisons of hashes for password checks to avoid any possible side-channel leaks that could be combined with other vectors to discover password lengths.
The
passwordfilemisuse ofsubtle.ConstantTimeComparecomes from upstream Kubernetes:https://github.com/kubernetes/kubernetes/blob/release-1.18/staging/src/k8s.io/apiserver/plugin/pkg/authenticator/password/passwordfile/passwordfile.go
Types of Changes
bugfix
Verification
Normal CI and release testing (no visible user impact)
Testing
Linked Issues
User-Facing Change
Further Comments