Add el9 selinux rpm #7443
Merged
Add el9 selinux rpm #7443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
brandond
approved these changes
May 5, 2023
briandowns
approved these changes
May 5, 2023
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
brandond
reviewed
May 8, 2023
| @@ -518,7 +518,7 @@ setup_selinux() { | |||
| rpm_target=el7 | |||
| rpm_site_infix=centos/7 | |||
| package_installer=yum | |||
| elif [ "${VERSION_ID%%.*}" = "8" ]; then | |||
| elif [ "${VERSION_ID%%.*}" = "8" ] || [ "${VERSION_ID%%.*}" = "37" ]; then | |||
There was a problem hiding this comment.
is Fedora 37 the only one that needs the EL8 packages, instead of EL7 or EL9?
There was a problem hiding this comment.
as far as I can see yes, it needs el8
There was a problem hiding this comment.
I recommend >= "37" so it can work for future releases of fedora.
There was a problem hiding this comment.
Well I think 38 and newer need EL9 packages, and 36 needs EL7? I'm not sure, but some clarification would be good.
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
brandond
approved these changes
May 15, 2023
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
|
I added a new modification to the PR to fix a problem with the upgrade: The problem:
To fix that we should either disable or remove k3s-selinux policy before upgrading container-selinux. |
johnatasr
approved these changes
May 22, 2023
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
brandond
reviewed
May 24, 2023
brandond
approved these changes
May 24, 2023
galal-hussein
added a commit
to galal-hussein/k3s
that referenced
this pull request
May 25, 2023
This reverts commit d55ec08.
galal-hussein
added a commit
to galal-hussein/k3s
that referenced
this pull request
May 25, 2023
This reverts commit d55ec08. Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
galal-hussein
added a commit
that referenced
this pull request
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of Changes
Install script
Testing
Linked Issues