-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Coredns user config #743
Conversation
ef7ac2e
to
60801e2
Compare
manifests/coredns.yaml
Outdated
data: | ||
EmptyExample: | | ||
# This is an example empty coredns configmap entry to silence warnings | ||
--- | ||
apiVersion: extensions/v1beta1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apiVersion: apps/v1 is better for k8s-v1.14.x, 😃
Can we decouple the image bump from the feature add? I would like to see a more recent version of coredns soon :) |
@erikwilson appreciate you opening this! is there any way I can help in order to get this PR to move forward? Very excited and appreciate you taking time to do this! |
@erikwilson I am wondering if we should do this to all manifests, the local storage PR also include a configmap that can be configured for different nodes https://github.com/rancher/k3s/pull/816/files#diff-0683dbb4f157e849170880c2b3a8049eR94 |
Thanks @mlebrun! The PR kind of stalled due to limitations with CoreDNS config. I would like to support a Unfortunately @galal-hussein I think this is using some CoreDNS specific tricks using the |
Right, if some version of this functionality could move forward, we would at least have something in the meantime, albeit maybe not perfect. But I would take that over having to modify my CoreDNS config on server restarts! As always, let me know if there's anything I can do outside of gentle nudging 😃 |
@erikwilson Any plans to revisit this PR? This feature would be extremely valuable for my dev tooling. |
Is this somehow superseded? (eg. by what's yet to come in #1899) |
Is this PR still relevant? |
Closing this PR as out-of-date (by 2 years) |
I don't see how #1899 has any relation to this PR. I need to modify the coredns config to do this: https://coredns.io/2017/05/08/custom-dns-entries-for-kubernetes/ But the Edit: I see, you're probably talking about Edit 2: I've confused |
Coming here today as I'm struggling with finding a proper way of modifying the CoreDNS configmap for k3d (e.g. to inject host.k3d.internal and records for the LB and registries, etc.). |
For #462
Provides a
coredns-user
configMap to separate k3s config from user config.Example: