Add adr for vpn integration #6221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelbuil
force-pushed
the
integrate-vpns
branch
2 times, most recently
from
b488bd3
to
a7cd308
Compare
manuelbuil
force-pushed
the
integrate-vpns
branch
from
a7cd308
to
360beec
Compare
Signed-off-by: Manuel Buil <mbuil@suse.com>
manuelbuil
force-pushed
the
integrate-vpns
branch
from
360beec
to
457585a
Compare
|
@manuelbuil I'm still excited to see some VPN coordinator integration, if you ever get back to this ;) |
I have the code ready but I am reluctant to create the PR as I'll be gone for 4 months... not sure what to do, do it now or wait 4 months |
matttrach
approved these changes
Dec 2, 2022
|
@manuelbuil can we revive this? |
The ADR is part of my other PR, the one that also contains the code: #7352 |
|
@manuelbuil ah got it, so should we close this one out? or is this a pre-req? |
|
Closing since the adr got merged with the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manuel Buil mbuil@suse.com