Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.30] Testing And Secrets-Encryption Backports for 2024-09 #10801

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Sep 3, 2024

Proposed Changes

Contains several (mostly E2E testing) backport

Types of Changes

Testing Improvements

Verification

Testing

All changes are covered by testing

Linked Issues

#10637

User-Facing Change

Update to newer OS images for install testing
Fix caching name for e2e vagrant box
Remove secrets encryption controller
Cover edge case when on new minor release for E2E upgrade test
Removes deprecated alpha Secrets Encryption metrics (deprecated in 1.30, removed in 1.31)

Further Comments

* Update to newer OS images for install testing
* Update vagrant images used for E2E

Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
* Remove secrets encryption controller

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner September 3, 2024 21:54
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 87 lines in your changes missing coverage. Please review.

Project coverage is 43.73%. Comparing base (98262b5) to head (bf50d88).
Report is 5 commits behind head on release-1.30.

Files with missing lines Patch % Lines
pkg/server/secrets-encrypt.go 0.00% 75 Missing ⚠️
pkg/secretsencrypt/config.go 0.00% 12 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (98262b5) and HEAD (bf50d88). Click for more details.

HEAD has 37 uploads less than BASE
Flag BASE (98262b5) HEAD (bf50d88)
unittests 3 1
inttests 30 10
e2etests 21 6
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.30   #10801      +/-   ##
================================================
- Coverage         49.72%   43.73%   -5.99%     
================================================
  Files               179      178       -1     
  Lines             14979    14894      -85     
================================================
- Hits               7448     6514     -934     
- Misses             6175     7188    +1013     
+ Partials           1356     1192     -164     
Flag Coverage Δ
e2etests 36.46% <0.00%> (-9.99%) ⬇️
inttests 36.82% <0.00%> (+0.15%) ⬆️
unittests 13.46% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 01faf4e into k3s-io:release-1.30 Sep 4, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants