Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.28] Fix agent supervisor port using apiserver port instead #10355

Merged

Conversation

brandond
Copy link
Member

Proposed Changes

Fix agent supervisor port using apiserver port instead

The agent's supervisor listener on RKE2 is using the wrong port. Didn't notice it here because they're the same in k3s.

Types of Changes

bugfix

Verification

Can only be tested in RKE2

Testing

Linked Issues

User-Facing Change

NONE

Further Comments

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner June 13, 2024 21:01
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.89%. Comparing base (b261f29) to head (76a5268).
Report is 1 commits behind head on release-1.28.

Files Patch % Lines
pkg/agent/https/https.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.28   #10355      +/-   ##
================================================
- Coverage         36.09%   35.89%   -0.20%     
================================================
  Files               163      160       -3     
  Lines             16644    14057    -2587     
================================================
- Hits               6007     5046     -961     
+ Misses             9621     8015    -1606     
+ Partials           1016      996      -20     
Flag Coverage Δ
e2etests 35.89% <50.00%> (-0.38%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit dd86a05 into k3s-io:release-1.28 Jun 13, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants