Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.29] Add snapshot retention etcd-s3-folder fix #10316

Merged

Conversation

* Add snapshot retention folder fix

Signed-off-by: Vitor Savian <vitor.savian@suse.com>

* Add snapshot retention E2E test

Signed-off-by: Vitor Savian <vitor.savian@suse.com>

---------

Signed-off-by: Vitor Savian <vitor.savian@suse.com>
@vitorsavian vitorsavian requested a review from a team as a code owner June 6, 2024 21:20
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 43.05%. Comparing base (485eaf3) to head (ee0562f).

Files Patch % Lines
pkg/etcd/s3.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.29   #10316      +/-   ##
================================================
- Coverage         50.07%   43.05%   -7.02%     
================================================
  Files               163      163              
  Lines             14204    14205       +1     
================================================
- Hits               7112     6116     -996     
- Misses             5753     6908    +1155     
+ Partials           1339     1181     -158     
Flag Coverage Δ
e2etests 36.24% <0.00%> (-10.40%) ⬇️
inttests 19.88% <0.00%> (-17.15%) ⬇️
unittests 16.38% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitorsavian vitorsavian merged commit 013ec43 into k3s-io:release-1.29 Jun 6, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants