Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix embedded mirror blocked by SAR RBAC and re-enable test #10257

Merged
merged 1 commit into from
May 31, 2024

Conversation

brandond
Copy link
Member

Proposed Changes

Fix embedded mirror blocked by SAR RBAC and re-enable test.

The embedded registry mirror was broken by #10019 - requests to the registry API are being run rejected by authz subject access reviews when they should not be. This is due to the AlwaysAllowPaths being incorrectly configured to match specific paths instead of prefixes.

Types of Changes

bugfix

Verification

see linked issue

Testing

Linked Issues

User-Facing Change

NONE

Further Comments

@brandond brandond requested a review from a team as a code owner May 30, 2024 21:07
dereknola
dereknola previously approved these changes May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 41.61%. Comparing base (307f07b) to head (a735911).

Files Patch % Lines
pkg/agent/https/https.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10257      +/-   ##
==========================================
- Coverage   47.79%   41.61%   -6.19%     
==========================================
  Files         177      177              
  Lines       14772    14775       +3     
==========================================
- Hits         7061     6149     -912     
- Misses       6364     7448    +1084     
+ Partials     1347     1178     -169     
Flag Coverage Δ
e2etests 36.49% <0.00%> (-9.82%) ⬇️
inttests 19.96% <0.00%> (-17.11%) ⬇️
unittests 11.33% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team May 31, 2024 07:20
@brandond brandond merged commit f9130d5 into k3s-io:master May 31, 2024
28 checks passed
@brandond brandond deleted the fix-embedded-mirror branch June 6, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants