Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue caused by sole server marked as failed under load #10241

Merged
merged 1 commit into from
May 30, 2024

Conversation

brandond
Copy link
Member

Proposed Changes

Fix issue caused by sole server marked as failed under load.

If health checks are failing for all servers, make a second pass through the server list with health-checks ignored before returning failure.

Types of Changes

bugfix

Verification

See linked issue - probably hard/impossible to reproduce on demand due to failure conditions

Testing

Linked Issues

User-Facing Change

The embedded load-balancer will now fall back to trying all servers with health-checks ignored, if all servers have been marked unavailable due to failed health checks.

Further Comments

@brandond brandond requested a review from a team as a code owner May 29, 2024 18:44
@brandond brandond force-pushed the ignore-health-all-failed branch 2 times, most recently from 5e42769 to 9e39851 Compare May 29, 2024 19:10
If health checks are failing for all servers, make a second pass through the server list with health-checks ignored before returning failure

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 41.73%. Comparing base (ed23a2b) to head (ca39614).

Files Patch % Lines
pkg/agent/loadbalancer/loadbalancer.go 83.33% 0 Missing and 1 partial ⚠️
pkg/etcd/etcdproxy.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10241      +/-   ##
==========================================
- Coverage   47.83%   41.73%   -6.11%     
==========================================
  Files         177      177              
  Lines       14765    14772       +7     
==========================================
- Hits         7063     6165     -898     
- Misses       6358     7428    +1070     
+ Partials     1344     1179     -165     
Flag Coverage Δ
e2etests 36.45% <83.33%> (-9.46%) ⬇️
inttests 37.08% <41.66%> (+<0.01%) ⬆️
unittests 11.34% <75.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants