Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 1.28] Replace deprecated ruby function #10090

Merged

Conversation

manuelbuil
Copy link
Contributor

Backport: #10084

@manuelbuil manuelbuil requested a review from a team as a code owner May 13, 2024 07:50
Signed-off-by: Manuel Buil <mbuil@suse.com>
@manuelbuil manuelbuil force-pushed the rubydeprecatedfunctione2e128 branch 2 times, most recently from 2626445 to b42d172 Compare May 16, 2024 15:22
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.22%. Comparing base (4021013) to head (b42d172).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.28   #10090      +/-   ##
================================================
+ Coverage         34.15%   36.22%   +2.06%     
================================================
  Files               158      155       -3     
  Lines             17343    13879    -3464     
================================================
- Hits               5924     5028     -896     
+ Misses            10421     7872    -2549     
+ Partials            998      979      -19     
Flag Coverage Δ
e2etests 36.22% <ø> (+0.05%) ⬆️
inttests ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manuelbuil manuelbuil merged commit f5dc8e7 into k3s-io:release-1.28 May 23, 2024
27 checks passed
@manuelbuil manuelbuil deleted the rubydeprecatedfunctione2e128 branch May 23, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants