Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow directory symlinks in auto deploying manifests (#9288) #10049

Merged
merged 1 commit into from
May 24, 2024

Conversation

rorosen
Copy link
Contributor

@rorosen rorosen commented Apr 30, 2024

Proposed Changes

I use k3s in NixOS and am affected by #9288, the auto-deploy controller does not follow symlinked directories. This is a little annoying since it's pretty normal to link large parts of the filesystem in NixOS.

Types of Changes

The deploy controller will now follow top-level symlink directories.

Verification

I tested the changes locally.

Testing

I couldn't find unit tests for the deploy controller and hence don't know what would be the best place for tests. Happy to add a test if required.

Linked Issues

User-Facing Change

Symlinked sub-directories are now respected when scanning Auto-Deploying Manifests (AddOns) 

@rorosen rorosen requested a review from a team as a code owner April 30, 2024 14:10
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 43.55%. Comparing base (fe7d114) to head (1aac62d).
Report is 3 commits behind head on master.

Files Patch % Lines
pkg/deploy/controller.go 0.00% 12 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10049      +/-   ##
==========================================
- Coverage   48.92%   43.55%   -5.37%     
==========================================
  Files         158      158              
  Lines       14032    14045      +13     
==========================================
- Hits         6865     6118     -747     
- Misses       5885     6762     +877     
+ Partials     1282     1165     -117     
Flag Coverage Δ
e2etests 36.37% <0.00%> (-10.41%) ⬇️
inttests 37.06% <0.00%> (?)
unittests 16.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola
Copy link
Member

BTRFS E2e failure can be ignored. Solved by #10057. You can rebase master if you really want to see "all green", but its not required 😄

Signed-off-by: Robert Rose <robert.rose@mailbox.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants