Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] The value of the type or label should not be used to generate the Relation id. #69

Merged
merged 4 commits into from
Feb 8, 2021

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Feb 8, 2021

No description provided.

@k1LoW k1LoW self-assigned this Feb 8, 2021
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #69 (4159e99) into main (b3fda01) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   53.97%   53.96%   -0.02%     
==========================================
  Files          13       13              
  Lines        1484     1477       -7     
==========================================
- Hits          801      797       -4     
+ Misses        564      562       -2     
+ Partials      119      118       -1     
Impacted Files Coverage Δ
config/relation.go 51.21% <ø> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3fda01...4159e99. Read the comment docs.

@k1LoW k1LoW merged commit 3ea4f5a into main Feb 8, 2021
@k1LoW k1LoW deleted the re-fix-relation-id branch February 8, 2021 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants