Relax version checking when using a custom K0sBinaryPath #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would this allow mixed version clusters? |
|
Possibly when using custom binary paths |
|
Maybe k0sctl could allow to omit the version in the config if the binaries will be uploaded. The version seems to be futile in this scenario. If the version is in the config, it seems logical to enforce it. |
|
And k0s doesn't protest |
|
It could also print a warning |
When k0s version is not set, latest is defaulted. |
Signed-off-by: Kimmo Lehto <klehto@mirantis.com> Add a warning Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
kke
force-pushed
the
dont-check-k0sbinarypath
branch
from
3a6bc10
to
ad9d6ec
Compare
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #740
Removes the remote k0s version check after binary installation when using a custom
K0sBinaryPath.