Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert kubeconfig modification functionality changes #732

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Revert kubeconfig modification functionality changes #732

merged 4 commits into from
Jun 28, 2024

Conversation

kke
Copy link
Contributor

@kke kke commented Jun 11, 2024 •
edited
Loading

This reverts commit 1afb01f from #720

The kubeconfig manipulation (address changes) is kept how it was before v0.18.0 but the reading of the kubeconfig is changed to use k0s kubeconfig admin instead of reading the file from datadir directly.

@kke kke added the bug Something isn't working label Jun 11, 2024
@kke kke changed the title Revert "k0sctl kubeconfig" changes made in #720 Revert kubeconfig modification functionality changes Jun 12, 2024
@kke
Copy link
Contributor Author

kke commented Jun 12, 2024

Something's wrong with the runners. Need to retry later.

time="2024-06-12T08:09:53Z" level=error msg="OCI runtime exec failed: exec failed: unable to start container process: error executing setns process: exit status 1: unknown" machine=k0s-manager0
time="2024-06-12T08:09:53Z" level=fatal msg="exit status 126"

time="2024-06-12T08:09:57Z" level=error msg="OCI runtime exec failed: exec failed: unable to start container process: error writing config to pipe: write init-p: broken pipe: unknown" machine=k0s-manager0

@kke kke mentioned this pull request Jun 25, 2024
Closed
@kke
Copy link
Contributor Author

kke commented Jun 25, 2024

I guess we could merge this without going green since it's a different problem in the CI that is causing the failure.

@kke kke force-pushed the revert-720 branch 4 times, most recently from 0592980 to 830865a Compare June 26, 2024 12:54
@kke
Copy link
Contributor Author

kke commented Jun 26, 2024

Looks like the docker downgrade workaround makes this green.

@kke
Copy link
Contributor Author

kke commented Jun 27, 2024

Going to try this without the docker downgrade once a fixed bootloose is baked.

@kke kke requested a review from twz123 June 27, 2024 12:56
kke added 4 commits June 28, 2024 09:45
@kke
Revert "Simplify kubeconfig retrieval by using k0s kubeconfig command (…
9fac5e5 
…#720)"

This reverts commit 1afb01f.

Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke
Replace reading admin.conf with reading output of "k0s kubeconfig admin"
84afc59 
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke
Reusable workflow steps for smoke tests and docker downgrade workaround
1ffeb01 
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke
Hide kubeconfig content from logs
be57cd7 
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke kke merged commit 5de0344 into main Jun 28, 2024
40 checks passed
@kke kke deleted the revert-720 branch June 28, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twz123 twz123 Awaiting requested review from twz123

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kke @twz123