Move k0s version defaulting into a phase #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kke
force-pushed
the
version-getter-phase
branch
2 times, most recently
from
cd5162f
to
14cb4a8
Compare
kke
force-pushed
the
version-getter-phase
branch
3 times, most recently
from
c10248e
to
df7405a
Compare
twz123
reviewed
Oct 13, 2023
kke
force-pushed
the
version-getter-phase
branch
from
df7405a
to
1fb8338
Compare
twz123
previously approved these changes
Oct 13, 2023
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
kke
force-pushed
the
version-getter-phase
branch
from
b4ea463
to
cd5b6ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #569
Closes #570 (alternate)
Adds a
DefaultK0sVersionphase that sets the k0s version when it has been left undefined.Adds a
spec.k0s.versionChannelconfig key for selecting between "stable" and "latest" channels for version lookups.