Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issues #966

Merged
merged 7 commits into from
Aug 31, 2024
Merged

Fix Issues #966

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d6306c6
Fix ruff-issues
ivanleomk Aug 30, 2024
5bb5004
Fix ruff issues
ivanleomk Aug 30, 2024
82b35c2
Fix type issues
ivanleomk Aug 30, 2024
495a3fa
Fix pyright issues
ivanleomk Aug 30, 2024
ad0fa91
Modifying extraction test
ivanleomk Aug 30, 2024
8ba8f79
Fix up partial test to no longer assert the change
ivanleomk Aug 30, 2024
299b9ef
Adding new Vertex AI and Gemini. Docs (#967)
ivanleomk Aug 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions tests/llm/test_vertexai/test_message_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
from .util import models, modes


@pytest.mark.parametrize("model, mode", [(models[0], modes[0])])
def test_vertexai_message_parser_string_content(model, mode):
def test_vertexai_message_parser_string_content():
message = {"role": "user", "content": "Hello, world!"}
result = vertexai_message_parser(message)

Expand All @@ -17,8 +16,7 @@ def test_vertexai_message_parser_string_content(model, mode):
assert result.parts[0].text == "Hello, world!"


@pytest.mark.parametrize("model, mode", [(models[0], modes[0])])
def test_vertexai_message_parser_list_content(model, mode):
def test_vertexai_message_parser_list_content():
message = {
"role": "user",
"content": [
Expand All @@ -40,16 +38,14 @@ def test_vertexai_message_parser_list_content(model, mode):
assert result.parts[2].text == " How are you?"


@pytest.mark.parametrize("model, mode", [(models[0], modes[0])])
def test_vertexai_message_parser_invalid_content(model, mode):
def test_vertexai_message_parser_invalid_content():
message = {"role": "user", "content": 123} # Invalid content type

with pytest.raises(ValueError, match="Unsupported message content type"):
vertexai_message_parser(message)


@pytest.mark.parametrize("model, mode", [(models[0], modes[0])])
def test_vertexai_message_parser_invalid_list_item(model, mode):
def test_vertexai_message_parser_invalid_list_item():
message = {"role": "user", "content": ["Hello", 123, gm.Part.from_text("world!")]}

with pytest.raises(ValueError, match="Unsupported content type in list"):
Expand Down
Loading