Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct small typos on Structured Output post #945

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

ivanleomk
Copy link
Collaborator

@ivanleomk ivanleomk commented Aug 22, 2024

🚀 This description was created by Ellipsis for commit 9869ffb

Summary:

Corrects typos in docs/blog/posts/introducing-structured-outputs.md, updating mode and model parameters in code examples for accuracy.

Key points:

  • Corrected mode parameter from instructor.Mode.TOOLS to instructor.Mode.TOOLS_STRICT in docs/blog/posts/introducing-structured-outputs.md.
  • Updated model parameter from gpt-4 to gpt-4o-mini in the same file.
  • Ensured code examples reflect accurate usage of instructor and OpenAI models.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9869ffb in 10 seconds

More details
  • Looked at 31 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. docs/blog/posts/introducing-structured-outputs.md:231
  • Draft comment:
    Ensure that instructor.Mode.TOOLS_STRICT is the intended mode for this example, as it changes the behavior of the client. This change is consistent with the context of strict validation and retries discussed in the article.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from instructor.Mode.TOOLS to instructor.Mode.TOOLS_STRICT is intentional and aligns with the context of the article, which discusses strict validation and retries.
2. docs/blog/posts/introducing-structured-outputs.md:262
  • Draft comment:
    Verify that gpt-4o-mini is the intended model for this example, as it differs from the original gpt-4. This change should align with the context and purpose of the example.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from gpt-4 to gpt-4o-mini should be verified to ensure it aligns with the intended model for this example.
3. docs/blog/posts/introducing-structured-outputs.md:259
  • Draft comment:
    If the model name change is part of the library code, ensure that the documentation is updated accordingly to reflect this change.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The PR changes the model name in the code example, which is part of the library code. This requires an update in the documentation to reflect the change.

Workflow ID: wflow_TkjCXMSnfrYpUs1e


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Deploying instructor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9869ffb
Status: ✅  Deploy successful!
Preview URL: https://e82b1516.instructor.pages.dev
Branch Preview URL: https://fix-typo-in-structured-outpu.instructor.pages.dev

View logs

@ivanleomk ivanleomk requested a review from jxnl August 22, 2024 15:49
@ivanleomk ivanleomk merged commit ad8e27e into main Aug 22, 2024
14 of 15 checks passed
@ivanleomk ivanleomk deleted the fix-typo-in-structured-output-post branch August 22, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants