-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new cli for batch jobs #754
Conversation
Deploying instructor with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 3badff5 in 1 minute and 15 seconds
More details
- Looked at
211
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_3LI3kzPyGPA6FGJO
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on 7a63dfb in 1 minute and 56 seconds
More details
- Looked at
23
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_5kWT7MemEldzO2Vz
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on f0f3e54 in 3 minutes and 11 seconds
More details
- Looked at
49
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_bPuD4CewQk6OgWvI
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on db0ba28 in 2 minutes and 3 seconds
More details
- Looked at
49
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. instructor/cli/batch.py:78
- Draft comment:
The use of...
intyper.Option
is unnecessary when a help message is provided. It should be removed to avoid potential confusion.
file_path: str = typer.Option(help="File containing the batch job requests"),
- Reason this comment was not posted:
Confidence of 30% on close inspection, compared to threshold of 85%.
2. instructor/cli/batch.py:100
- Draft comment:
The use of...
intyper.Option
is unnecessary when a help message is provided. It should be removed to avoid potential confusion.
batch_id: str = typer.Option(help="Batch job ID to cancel"),
- Reason this comment was not posted:
Confidence of 80% on close inspection, compared to threshold of 85%.
Workflow ID: wflow_6WUeznJX5ZWrqr2v
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
please add a lil recording and doc pages before we're ready to merge |
This is a video recording of the cli in action where we use a generated batch_recording.mp4Also added a docs page which shows a new snippet on how to generate these .jsonl files |
This reverts commit 79f6904.
When can we expect the next release to include this? Excited to use this batch CLI command |
@slavakurilyak we just released v1.3.4 which has it! |
This targets #604 by implementing two main new features
BatchJob
class which allows users to create.jsonl
files which are compatible with OpenAI's new batch job functionSummary:
This PR introduces a new
BatchJob
class and CLI commands for managing batch jobs with OpenAI's API.Key points:
BatchJob
class ininstructor/batch.py
for creating.jsonl
files for batch jobs.instructor/cli/batch.py
to list, create, and cancel batch jobs.instructor/cli/cli.py
.Generated with ❤️ by ellipsis.dev