Iterable Workaround #737
Merged
Iterable Workaround #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying instructor with
|
| Latest commit: |
43a47a7
|
| Status: | ⚡️ Build in progress... |
jxnl
reviewed
Jun 10, 2024
| import typing | ||
|
|
||
|
|
||
| class SimpleTypeTests(unittest.TestCase): |
jxnl
reviewed
Jun 10, 2024
| @@ -31,14 +31,27 @@ def __class_getitem__(cls, response_model: type[BaseModel]) -> type[BaseModel]: | |||
| ) | |||
|
|
|||
|
|
|||
| def validateIsSubClass(response_model: type): | |||
jxnl
reviewed
Jun 10, 2024
| @@ -54,6 +54,7 @@ def ask_ai(content, model, client) -> DocumentExtraction: | |||
| "content": content, | |||
| }, | |||
| ], | |||
| max_retries=4, | |||
bllchmbrs
pushed a commit
to bllchmbrs/instructor
that referenced
this pull request
Jun 14, 2024
Co-authored-by: Jason Liu <jxnl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps solve issue #668 which highlighted an issue with how we're handling Iterables in Python 3.9. There's a bunch of new tests and a new wrapper function which checks the system python version before running the iterable check.