fix(parallel): enhance error handling in get_types_array and add test case #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellipsis-dev
bot
changed the title
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good to me!
Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository.
Generated with ❤️ by ellipsis.dev
jxnl
commented
Feb 9, 2024
| def test_sync_parallel_tools__error(client): | ||
| client = instructor.patch(client, mode=instructor.Mode.PARALLEL_TOOLS) | ||
|
|
||
| with pytest.raises(TypeError): |
There was a problem hiding this comment.
@lukevs We should definitely be switching back to regular tools mode if we can detect that it's not an iterable.
There was a problem hiding this comment.
Need it still for the Boy | Girl case too right (to get the name disambiguation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR enhances error handling in
get_types_arrayfunction and adds a corresponding test case.Key points:
get_types_arrayfunction ininstructor/dsl/parallel.pyto raiseTypeErrorfor non-iterable models.test_sync_parallel_tools__errorintests/openai/test_parallel.py.Generated with ❤️ by ellipsis.dev