-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to implement new retires #386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested.
Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository.
Generated with ❤️ by ellipsis.dev
@@ -352,56 +352,79 @@ def retry_sync( | |||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function documentation for retry_sync
needs to be updated to reflect the changes in the function's behavior. Specifically, the max_retries
parameter can now be an int or a tenacity.Retrying
object. Please update the function documentation accordingly.
Also, please ensure that the tests for this function are updated to cover the new functionality.
Summary:
This PR enhances the retry logic in
retry_sync
function ofinstructor/patch.py
by implementingtenacity.Retrying
object and adding error handling for invalidmax_retries
input.Key points:
retry_sync
function ininstructor/patch.py
.tenacity.Retrying
object.max_retries
input.Generated with ❤️ by ellipsis.dev