Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json scheme example change #316

Merged
merged 3 commits into from
Jan 1, 2024
Merged

json scheme example change #316

merged 3 commits into from
Jan 1, 2024

Conversation

Phodaie
Copy link
Contributor

@Phodaie Phodaie commented Jan 1, 2024

No description provided.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment issue

Summary:

This PR updates a JSON schema example in a blog post and corrects a comment in a validation script.

Key points:

  • Modified JSON schema example in 'docs/blog/posts/chain-of-density.md'.
  • Updated a comment in 'examples/validators/llm_validator.py'.

Generated with ❤️ by ellipsis.dev

@@ -35,7 +35,7 @@ class QuestionAnswer(BaseModel):
print("Before validation with `llm_validator`")
print(qa.model_dump_json(indent=2), end="\n\n")
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment for the print statement is incorrect. It should be 'After validation with llm_validator' instead of 'Before validation with llm_validator'. Please correct it.

@jxnl jxnl merged commit afbf272 into jxnl:main Jan 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants