Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public API #82

Merged
merged 6 commits into from
Jun 9, 2021
Merged

Add public API #82

merged 6 commits into from
Jun 9, 2021

Conversation

pascal20997
Copy link
Contributor

No description provided.

@pascal20997 pascal20997 added this to the v1.2 milestone Jun 8, 2021
@pascal20997 pascal20997 requested a review from froemken June 8, 2021 10:24
@pascal20997 pascal20997 marked this pull request as draft June 8, 2021 10:42
@pascal20997 pascal20997 marked this pull request as ready for review June 8, 2021 12:39
Classes/Service/ReserveService.php Show resolved Hide resolved
You can use this class in your own extension to get some information like remaining participants of a period.

If you want even more, then you can use the other Service classes, Repositories and so on too but make sure that some
functionality can change in coming versions. We try to keep compatibility but sometimes breaking changes are required.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"upcoming"

Documentation/Extend reserve/UpdateTemplates/Index.rst Outdated Show resolved Hide resolved
@@ -51,7 +51,7 @@ protected function setUp(): void
// set date to past date for this tests!
GeneralUtility::makeInstance(ConnectionPool::class)
->getConnectionForTable('tx_reserve_domain_model_period')
->update('tx_reserve_domain_model_period', ['date' => '1608768000'], ['uid' => 1]);
->update('tx_reserve_domain_model_period', ['date' => (new \DateTime('yesterday midnight'))->getTimestamp() ], ['uid' => 1]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leerzeichen zuviel.

*/
protected $testDateMidnight;

protected function setUp()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:void

@pascal20997 pascal20997 merged commit f81cc83 into master Jun 9, 2021
@pascal20997 pascal20997 deleted the featureApi branch June 9, 2021 13:24
sfroemkenjw pushed a commit that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants