Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom orders #64

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Allow custom orders #64

merged 2 commits into from
Nov 9, 2020

Conversation

DanielSiepmann
Copy link
Contributor

@DanielSiepmann DanielSiepmann commented Oct 22, 2020

Move logic to order:

  • Is order bookable
  • Should further order be prevented

That way the order contains all their info.
Further orders can be created, e.g. by extending the model and
overwriting the logic.

Add further (optional) fields.
Add first and last name for each reservation.
Allow external code to hook into validation, to add custom validation.
Move logic to order:

    * Is order bookable
    * Should further order be prevented

That way the order contains all their infos.
Further orders can be created, e.g. by extending the model and
overwriting the logic.
@DanielSiepmann
Copy link
Contributor Author

On top of #63, therefore #63 has to be merged beforehand.

@DanielSiepmann
Copy link
Contributor Author

An example usage can be found here: https://github.com/werkraum-media/reserve_extended/pull/3 There we add group orders as another type.

@pascal20997
Copy link
Contributor

I like how this extension gets more and more extendable

@pascal20997 pascal20997 merged commit c634289 into jweiland-net:master Nov 9, 2020
sfroemkenjw pushed a commit that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants