refactor: remove redundant trimSuffix of new lines after toYaml

[consideRatio]

In the past toYaml created a new line that we trimmed away - but I contributed a fix to that in helm/helm so now it doesn't in the modern versions of the helm CLI which the JupyterHub helm chart now require anyhow :)

[manics]

Is the minimum Helm version enforced in the chart?

[consideRatio]

The minimum Helm version for this chart is 3.5.0, and it will error without that version so it is enforced due to that. Helm 3.5.0 behaves in a way making the trimSuffix part redundant.

I'm not sure when in helm 3 this was fixed because it was first merged and then reverted and then merged back due to them wanting to wait for the change until helm3 sometime as there was some chart that broke when this toYaml behaviour changed.

I concluded also that our helm diff test step in the CI jobs making a upgrade from a previous version also didn't report any changes to the rendered outcome.

[manics]

Thanks for confirming. I was worried changes like this might lead to strange error messages for someone using an out of date Helm (as opposed to new syntax which would fail immediately) but it sounds like it's all taken care of 😄