Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema: catch typos in template values using JSONSchema's additionalProperties #2200

Merged
merged 5 commits into from
May 18, 2021
Merged

schema: catch typos in template values using JSONSchema's additionalProperties #2200

merged 5 commits into from
May 18, 2021

Commits on May 18, 2021

  1. schema: catch typos in values using additionalProperties 

    Our schema.yaml file is rendered into values.schema.json and shipped
with the Helm chart. It is a JSONSchema that covers all the
configuration options or allows arbitrary configuration where it doesn't
explicitly cover it.

With this enabled we will catch almost all typos in values passed to the
Helm chart, but on the other hand we will also cause some disruptions
during `helm upgrade` commands before any changes has been made where we
previously ignored configuration that wasn't recognized.
    @consideRatio
    consideRatio committed May 18, 2021
    Configuration menu
    Copy the full SHA
    e41f93b View commit details
    Browse the repository at this point in the history

  2. schema: accept deprecated values, let NOTES.txt render helpful errors

    @consideRatio
    consideRatio committed May 18, 2021
    Configuration menu
    Copy the full SHA
    662b6ad View commit details
    Browse the repository at this point in the history

  3. schema: accept additional deprecated values

    @consideRatio
    consideRatio committed May 18, 2021
    Configuration menu
    Copy the full SHA
    ff09572 View commit details
    Browse the repository at this point in the history

  4. schema: fix schema for cloudmetadata to handle deprecation messages

    @consideRatio
    consideRatio committed May 18, 2021
    Configuration menu
    Copy the full SHA
    e1c4083 View commit details
    Browse the repository at this point in the history

  5. ci: trigger test-chart workflow on schema changes

    @consideRatio
    consideRatio committed May 18, 2021
    Configuration menu
    Copy the full SHA
    1f31321 View commit details
    Browse the repository at this point in the history