Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal and explicit resource requests for image-puller pods #1764

Commits on Sep 1, 2020

  1. Set configurable minimal resource requests for image-puller daemonset…

    … pods
    
    If a k8s cluster has a LimitRange resource, it may end up for example
    allocating 100m CPU for containers which is a waste of resources. This
    would be a waste as the running container only does `sh -c "Done!"`
    anyhow. While there is image pulling happening, that is done before the
    actual container starts so its worth noting we don't need any resources
    specified for that.
    
    Another reason for specifying resources, and making them configurable,
    is that sometimes there is a ResourceQuota resource that requires the
    resources to be explicitly specified on pods.
    
    Related:
    - Default CPU requests - https://kubernetes.io/docs/tasks/administer-cluster/manage-resources/cpu-default-namespace/
    - LimitRange https://kubernetes.io/docs/concepts/policy/limit-range/
    - ResourceQuota - https://kubernetes.io/docs/concepts/policy/resource-quotas/
    consideRatio committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    1ddafd3 View commit details
    Browse the repository at this point in the history