[MRG] sphinx: linkcheck in travis (allowed to fail) #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manics
changed the title
|
Excellent @manics :D 🎉 |
|
https://travis-ci.org/github/jupyterhub/zero-to-jupyterhub-k8s/jobs/668203765#L371 Makes it easy to see what links are broken! Nice work. Is there a way to link to the output of the latest travis link check job on master? Then we could make a issue with that link that says "want to learn about sphinx and contribute to our docs? Fix a broken link (see list here) and submit a PR" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #724
Runs the Sphinx linkcheck in Travis, currently allowed to fail.
Although this means the docs are built twice (in Circle CI and Travis) I think it's clearer to have all the build statuses in one place, and the overhead of building the docs is small compared to that of running the deployment tests.