Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CD with git tags #1450

Merged
merged 1 commit into from
Oct 19, 2019

Conversation

consideRatio
Copy link
Member

TravisCI would make two builds if a commit and a tag referencing this
commit was pushed. This could lead to duplication of chart build and
publishing jobs. So, I disabled the tag triggered builds before to avoid
this, in case we ended up with duplicated entries or failure due to
existing entries etc.

In this PR, with chartpress 0.4.2 and the --long flag, we can let both
bulds finish. There are some key benefits.

  1. We can now push a tag retrospectively now to trigger a build.
  2. We avoid a failure to build a tag because it was pushed not as the
    HEAD commit but some steps down the history.
  3. We can still build on all pushed commits to master for dev releases.

TravisCI would make two builds if a commit and a tag referencing this
commit was pushed. This could lead to duplication of chart build and
publishing jobs. So, I disabled the tag triggered builds before to avoid
this, in case we ended up with duplicated entries or failure due to
existing entries etc.

In this PR, with chartpress 0.4.2 and the --long flag, we can let both
bulds finish. There are some key benefits.

1. We can now push a tag retrospectively now to trigger a build.
2. We avoid a failure to build a tag because it was pushed not as the
HEAD commit but some steps down the history.
3. We can still build on all pushed commits to master for dev releases.
@consideRatio consideRatio merged commit 83af061 into jupyterhub:master Oct 19, 2019
@consideRatio consideRatio deleted the travis-cd-with-tags branch October 19, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant