Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more configurable options in helm chart #1338

Merged
merged 2 commits into from
Sep 6, 2019

Conversation

bitnik
Copy link
Contributor

@bitnik bitnik commented Jul 26, 2019

Added more configurable options into helm chart and updated jupyterhub_config.py for hub image accordingly.

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kenan! :D

I spotted a duplicated entry, but other than that, this LGTM!

images/hub/jupyterhub_config.py Outdated Show resolved Hide resolved
Co-Authored-By: Erik Sundell <erik.i.sundell@gmail.com>
@bitnik
Copy link
Contributor Author

bitnik commented Sep 6, 2019

thanks :)

@consideRatio consideRatio merged commit ec3b97d into jupyterhub:master Sep 6, 2019
@consideRatio
Copy link
Member

❤️ @bitnik thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants