Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2 #70

Closed
4 tasks done
dhirschfeld opened this issue Apr 11, 2018 · 9 comments
Closed
4 tasks done

Release 1.2 #70

dhirschfeld opened this issue Apr 11, 2018 · 9 comments

Comments

@dhirschfeld
Copy link
Collaborator

dhirschfeld commented Apr 11, 2018

It's probably about due and would stop the steady trickle of people confused that the examples in the README don't work because the functionality has never been released.

Plan of attack:

  • Triage issues
  • Tag 1.2
  • Release to PyPI
  • Create conda-forge recipe
@yuvipanda
Copy link
Collaborator

Hey @dhirschfeld! I unfortunately haven't had much time to deal with maintenance here, and likely won't in the future. Me (and the JupyterHub team!) would appreciate help with maintaining this authenticator. Would you consider helping us out with maintenance? I'd be happy to give you merge rights here and access to the PyPI package. What do you think?

@dhirschfeld
Copy link
Collaborator Author

dhirschfeld commented Apr 11, 2018

I'd be happy to help and was in fact just looking around to see what the release process is!

I'm familiar with conda but not so much pip/pypi. A good opportunity to learn I guess 😛

@yuvipanda
Copy link
Collaborator

@dhirschfeld I've invited you to this repo! If you give me your PyPI username I can give you rights there too!

There currently isn't any docs specific to this repo for making a release. I'm happy to answer any specific questions you have! When I did releases, I would:

  1. Do a local test to make sure things seem ok
  2. Add entries to the CHANGELOG, marking breaking changes if they exist
  3. Make a commit bumping version number.
  4. Make a git tag for this version number
  5. Upload to PyPI with twine

I appreciate the help a lot, thank you for volunteering your time and expertise! <3 🎉

@dhirschfeld
Copy link
Collaborator Author

I just created an account on PyPI with the username dhirschfeld

@yuvipanda
Copy link
Collaborator

yuvipanda commented Apr 11, 2018 via email

@dhirschfeld
Copy link
Collaborator Author

Thanks! I'll see what I can do to help out on the maintenance/admin side...

@yuvipanda
Copy link
Collaborator

/cc @minrk @choldgraf @willingc so y'all are aware :)

@dhirschfeld
Copy link
Collaborator Author

Right, done and dusted! Version 1.2.0 is available on pypi, and shortly conda-forge.

Hopefully there are no problems but if there are I'll just fix them and make a quick patch release...

@choldgraf
Copy link
Member

way to go @dhirschfeld !!! thanks for the help :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants