Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade JupyterLab dependencies to v4.2.5 #7447

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

Copy link
Contributor

Binder 👈 Launch a Binder on branch krassowski/notebook/bump-versions-7.2.x

@krassowski
Copy link
Member Author

The CI is all good, but I see some errors in console and problems with full windowing mode. I am not sure if these are regressions or not - it would be great to check before releasing.

@RRosio
Copy link
Collaborator

RRosio commented Aug 26, 2024

Thank you @krassowski! I was looking at your updates about this error in #7423. Would you say this error should be addressed in a separate PR before this is merged and released?

@krassowski
Copy link
Member Author

I think we may want a bit more time to investigate, especially the windowing issue. I am not sure if we want to merge this one as is and iterate or wait but I think we should not release yet.

@krassowski
Copy link
Member Author

@RRosio after a bit more testing on my end I do not see a reason to wait with this one - the error discussed in #7423 is also occurring in the released 7.2.0 version and the notebooks work well both in windowing mode and without it

@RRosio
Copy link
Collaborator

RRosio commented Aug 27, 2024

Thank you @krassowski, I will merge this and go ahead with a release for 7.2.x!

@RRosio RRosio merged commit 0426a89 into jupyter:7.2.x Aug 27, 2024
31 checks passed
@krassowski krassowski deleted the bump-versions-7.2.x branch August 27, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants