Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook 6 CI updates #7344

Draft
wants to merge 2 commits into
base: 6.5.x
Choose a base branch
from
Draft

Notebook 6 CI updates #7344

wants to merge 2 commits into from

Conversation

RRosio
Copy link
Collaborator

@RRosio RRosio commented Apr 26, 2024

  • check-links
  • python tests on macos
  • python tests on windows
  • selenium tests

@@ -56,7 +56,7 @@ Launch with:

### Running in a remote installation

You need some configuration before starting Jupyter notebook remotely. See [Running a notebook server](https://jupyter-notebook.readthedocs.io/en/stable/public_server.html).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to point to older version of Jupyter notebook docs instead? The jupyter-server options will not work with the notebook server.

@@ -65,3 +65,5 @@ jobs:
- name: Check Links
if: ${{ matrix.group == 'link_check' }}
uses: jupyter-server/jupyter_releaser/.github/actions/check-links@v1
with:
ignore-links: 'https://travis-ci.org/jupyter/notebook.svg?branch=master'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo that link sounds be just removed, wherever it is.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback @krassowski! I have removed this link and updated the public server docs link to point to the 6.5.4 docs build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants