Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for nbgrader as a webapp #786

Merged
merged 6 commits into from
Jul 7, 2017

Conversation

jhamrick
Copy link
Member

@jhamrick jhamrick commented Jul 7, 2017

This adds the relevant docs for #782

I also included a few other minor changes to the docs that I noticed while I was working on this.

@willingc if you'd be willing to look at this that would be fantastic!

@jhamrick jhamrick added this to the 0.5.0 milestone Jul 7, 2017
@jhamrick jhamrick requested a review from willingc July 7, 2017 18:28
Copy link
Member

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks wonderful! Some minor edit suggestions 🎉

assignment and grading tasks using the familiar Jupyter notebook interface.
For example, creating an assignment has the following workflow:

The nbgrader toolbar extension for Jupyter notebooks guides the instructor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nbgrader toolbar extension

Instructor "formgrader" extension for Jupyter notebooks
-------------------------------------------------------

The formgrader extension for the Jupyter notebook allows instructors to use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formgrader extension

Student assignment list extension for Jupyter notebooks
-------------------------------------------------------

Using the assignment list extension, students may conveniently view, fetch,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assignment list extension

@@ -31,23 +31,16 @@ this was done using the ``nbgrader extension install`` command. However, moving
forward this is done using the ``jupyter nbextension`` and ``jupyter
serverextension`` commands.

To install and enable all frontend nbextensions (*assignment list*,
*create assignment*, and *formgrader*) run::
To install and enable all nbextensions (*assignment list*, *create assignment*,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would bold these instead of italics.

To work properly, the *assignment list* and *formgrader* extensions requires
both the nbextension and serverextension. The *create assignment* extension
only has an nbextension part.
To work properly, the *assignment list*, *formgrader*, and *validate*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here re: bold

@@ -85,16 +85,15 @@ work).
Configuration files
~~~~~~~~~~~~~~~~~~~

You will almost always need a configuration file as you are using nbgrader. At a minimum, this configuration file will contain information such as the names of the assignments for your class and the names of your students (though you may also add these by hand using the command line, see :doc:`creating_and_grading_assignments`). A basic config file would live at ``{course_directory}/nbgrader_config.py`` and might look like:
You may need a configuration file as you are using nbgrader to customize
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

You may need a configuration file as you are using nbgrader to customize
nbgrader's behavior. If you are using nbgrader with :doc:`JupyterHub
</configuration/jupyterhub_config>`, you will at minimum need to set the course
id in the configuration file. A basic config file would live at
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jupyterhub, jupyter, or nbgrader config file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to be overly specific when it comes to names of config files.

You will almost always need a configuration file as you are using nbgrader. At a minimum, this configuration file will contain information such as the names of the assignments for your class and the names of your students (though you may also add these by hand using the command line, see :doc:`creating_and_grading_assignments`). A basic config file would live at ``{course_directory}/nbgrader_config.py`` and might look like:
You may need a configuration file as you are using nbgrader to customize
nbgrader's behavior. If you are using nbgrader with :doc:`JupyterHub
</configuration/jupyterhub_config>`, you will at minimum need to set the course
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...you will at minimum need must set the course id in the nbgrader_config.py configuration file.

@jhamrick
Copy link
Member Author

jhamrick commented Jul 7, 2017

Thanks, @willingc , great comments! I'll address these now.

@jhamrick jhamrick merged commit 7e5f308 into jupyter:master Jul 7, 2017
@jhamrick jhamrick deleted the ui-docs branch July 7, 2017 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants