Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the number of test reruns even higher #649

Merged
merged 3 commits into from
Jan 15, 2017
Merged

Conversation

jhamrick
Copy link
Member

This is an interim effort to deal with the IOPub timeouts we're getting in the windows tests, until jupyter/nbconvert#513 is merged and released. Not sure if this will actually help all that much, but let's see!

cf #644
cc @lgpage

@jhamrick jhamrick added this to the 0.4.0 milestone Jan 14, 2017
@jhamrick
Copy link
Member Author

Meh. So far, does not seem to really help.

@jhamrick
Copy link
Member Author

Woo! Ok, the combination of bumping the number of reruns, and also re-executing notebooks if necessary, seems to have done the trick. Hacky solution, but good enough for now at least! 🎉

@jhamrick jhamrick merged commit 8c316e1 into jupyter:master Jan 15, 2017
@jhamrick jhamrick deleted the rerun branch January 15, 2017 00:25
@lgpage
Copy link
Member

lgpage commented Feb 6, 2017

Found this while trying to sort some other issue I have with running tests:

On Windows, the default proxy setting may cause a massive network latency (see Known Issues in the release note). The workaround is to disable proxy completely, e.g. by launching PhantomJS with --proxy-type=none command-line argument.

I wonder if this would help with running tests?

@jhamrick
Copy link
Member Author

jhamrick commented Feb 6, 2017

Hmm, interesting. I don't know if it will fix the problem but it's worth a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants