Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and use a Gradebook contextmanager for DbApp and DbApp tests #639

Merged
merged 7 commits into from
Jan 13, 2017

Conversation

lgpage
Copy link
Member

@lgpage lgpage commented Jan 13, 2017

Should fix #631

cc @ellisonbg

@lgpage lgpage added the bugfix label Jan 13, 2017
@lgpage lgpage added this to the 0.4.0 milestone Jan 13, 2017
@lgpage
Copy link
Member Author

lgpage commented Jan 13, 2017

@jhamrick I started messing around with AppVeyor CI for nbgrader and quickly tested this here and the python tests passed, but if you could please confirm if the tests pass on jenkins or not.

@jhamrick
Copy link
Member

Nice. This makes me think I really should have just made the Gradebook a context manager to begin with, i.e. so you could do with Gradebook("sqlite:///gradebook.db") as gb:. But that would be a fairly major change -- maybe something to do for 0.5.0 😉

I will test this out on Jenkins now.

@lgpage
Copy link
Member Author

lgpage commented Jan 13, 2017

Yeah making Gradebook a context manager would be nice 😄

@jhamrick
Copy link
Member

Ok, Jenkins finished. The tests are failing on 2.7 but I think that's an unrelated issue. Thanks for fixing this!

@jhamrick jhamrick merged commit 2c9113d into jupyter:master Jan 13, 2017
@lgpage lgpage deleted the fix-win branch January 13, 2017 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix nbgrader db tests on windows
2 participants