Fix Windows tests #608
Merged
Fix Windows tests #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamrick
force-pushed
the
windows-tests
branch
from
e74b642
to
827d59b
Compare
|
I am going to go ahead and merge this, but I won't cut the patch release @lgpage until I know the tests on appveyor are passing -- happy to make another PR if there are still things to fix! |
jhamrick
added a commit
to jhamrick/nbgrader
that referenced
this pull request
Jan 7, 2017
Fixes jupyter#599 (I think) @lgpage if you could see if this helps on conda forge that would be great -- I *think* the issue really is just spurious test cases so I added in a pytest plugin that will rerun failed tests. This fixed the test failures at least on the Jenkins build server, so I'm hoping it will on appveyor too. (There are a few other changes in this PR that address issues I was having with getting the tests to run on Jenkins, but the main thing is adding the `pytest-rerunfailures` to the dev requirements and then adding `--rerun=1` to the pytest command).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #599 (I think)
@lgpage if you could see if this helps on conda forge that would be great -- I think the issue really is just spurious test cases so I added in a pytest plugin that will rerun failed tests. This fixed the test failures at least on the Jenkins build server, so I'm hoping it will on appveyor too.
(There are a few other changes in this PR that address issues I was having with getting the tests to run on Jenkins, but the main thing is adding the
pytest-rerunfailuresto the dev requirements and then adding--rerun=1to the pytest command).