Loosen the traitlets version requirement #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The requirement of a specific traitlets version was first set in commit 35ed7aa to be <5.2 because apparently 5.2 broke tests. The last time this line was updated was in jupyter#1704, where it was bumped up to allow the latest version at the time, 5.6, by setting the value to <5.7. There was an additional change in jupyter#1704 which sets a log level, but this seems to be backwards compatible. These changes seem to no longer be relevant as the test suite now passes with traitlets versions 5.2, 5.7, as well as many others >5. The only version I found to fail was 5.0.0. This commit loosens the version requirement to allow these other versions of the traitlets package which don't cause known conflicts, as well as allow future minor, but not major version bumps.
|
|
|
Thanks @shreve, I was planning to do the same before the next release 👍 |
|
Haha, great timing then! Not sure if you're in the northern hemisphere, but spring is in the air here, and it feels like time for some spring cleaning! 🌷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The requirement of a specific traitlets version was first set in commit 35ed7aa to be <5.2 because apparently 5.2 broke tests.
The last time this line was updated was in #1704, where it was bumped up to allow the latest version at the time, 5.6, by setting the value to <5.7. There was an additional change in #1704 which sets a log level, but this seems to be backwards compatible.
These changes seem to no longer be relevant as the test suite now passes with traitlets versions 5.2, 5.7, as well as many others >5. The only version I found to fail was 5.0.0.
This commit loosens the version requirement to allow these other versions of the traitlets package which don't cause known conflicts, as well as allow future minor, but not major version bumps.