Skip to content

Commit

Permalink
Don't create the gradebook database until formgrader is accessed
Browse files Browse the repository at this point in the history
  • Loading branch information
jhamrick committed May 30, 2017
1 parent fe6bc0f commit 71685ab
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 3 deletions.
12 changes: 11 additions & 1 deletion nbgrader/server_extensions/formgrader/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

from tornado import web
from notebook.base.handlers import IPythonHandler
from ...api import Gradebook


class BaseHandler(IPythonHandler):
Expand All @@ -11,9 +12,18 @@ class BaseHandler(IPythonHandler):
def base_url(self):
return super(BaseHandler, self).base_url.rstrip("/")

@property
def db_url(self):
return self.settings['nbgrader_db_url']

@property
def gradebook(self):
return self.settings['nbgrader_gradebook']
self.log.debug("getting gradebook")
gb = self.settings['nbgrader_gradebook']
if gb is None:
gb = Gradebook(self.db_url)
self.settings['nbgrader_gradebook'] = gb
return gb

@property
def mathjax_url(self):
Expand Down
4 changes: 2 additions & 2 deletions nbgrader/server_extensions/formgrader/formgrader.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

from . import handlers, apihandlers
from ...apps.baseapp import NbGrader
from ...api import Gradebook


class FormgradeExtension(NbGrader):
Expand Down Expand Up @@ -38,7 +37,8 @@ def init_tornado_settings(self, webapp):
nbgrader_notebook_dir_format=self.coursedir.directory_structure,
nbgrader_step=self.coursedir.autograded_directory,
nbgrader_exporter=HTMLExporter(config=self.config),
nbgrader_gradebook=Gradebook(self.coursedir.db_url),
nbgrader_gradebook=None,
nbgrader_db_url=self.coursedir.db_url,
nbgrader_jinja2_env=jinja_env,
nbgrader_notebook_url_prefix=os.path.relpath(self.coursedir.root)
)
Expand Down

0 comments on commit 71685ab

Please sign in to comment.