Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the ignored part of IPython outputs #202

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

frenzymadness
Copy link
Contributor

With IPython 8.1, there is again a difference in tracebacks which causes three tests of nbclient to fail like this:

E             Full diff:
E               [
E                {'ename': 'KeyboardInterrupt',
E                 'evalue': '',
E                 'output_type': 'error',
E                 'traceback': ['---------------------------------------------------------------------------',
E                               'KeyboardInterrupt                         Traceback (most '
E                               'recent call last)',
E             -                 '<IPY-INPUT> in <cell line: 1>()\n'
E             ?                                  ^ ---------- --
E             +                 '<IPY-INPUT> in <module>\n'
E             ?                                  ^^^^^
E                               '----> 1 while True: continue\n',
E                               'KeyboardInterrupt: ']},
E               ]

nbclient/tests/test_client.py:231: AssertionError
…
=========================== short test summary info ============================
FAILED nbclient/tests/test_client.py::test_run_all_notebooks[Interrupt.ipynb-opts6]
FAILED nbclient/tests/test_client.py::test_run_all_notebooks[Skip Exceptions with Cell Tags.ipynb-opts8]
FAILED nbclient/tests/test_client.py::test_run_all_notebooks[Skip Exceptions.ipynb-opts9]
============ 3 failed, 73 passed, 106 warnings in 65.37s (0:01:05) =============

It seems to me that it's good idea to extend the ignored part of IPython input so I've prepared the regexes for that.

@davidbrochart
Copy link
Member

Thanks @frenzymadness, the CI failures are unrelated.

@davidbrochart davidbrochart merged commit 3d10059 into jupyter:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants