Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix helm chart logic error #1352

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

alex-treebeard
Copy link
Contributor

This enables successful usage of deployment nodeselectors, tolerations, and affinity. These were previously disabled due to a scoping issue.

This enables successful usage of deployment nodeselectors, tolerations, and affinity. These were previously disabled due to a scoping issue.
Copy link

welcome bot commented Dec 5, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes - great catch @alex-treebeard - thank you!

@kevin-bates kevin-bates merged commit baeeb50 into jupyter-server:main Dec 5, 2023
13 of 14 checks passed
Copy link

welcome bot commented Dec 5, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants