Change the default mode of CachingOptimizer #1254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another way of fixing #1249.
The default of a
CachingOptimizer
is to initialize inATTACHED_OPTIMIZER
mode. This has two consequences:copy_to
available.It seems like a much more sensible default is to initialize in
EMPTY_OPTIMIZER
mode.copy_to
if available.This is breaking (see the test change), so we may want to hold off until MOI 0.10, but it does need doing.