Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error for unsupported container syntax like x[A][B] #3756

Merged
merged 2 commits into from
May 26, 2024

Conversation

odow
Copy link
Member

@odow odow commented May 26, 2024

Closes #3755

src/Containers/macro.jl Outdated Show resolved Hide resolved
test/test_macros.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (48a4f74) to head (399ce62).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3756   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          44       44           
  Lines        5867     5869    +2     
=======================================
+ Hits         5772     5774    +2     
  Misses         95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit fad385c into master May 26, 2024
11 checks passed
@odow odow deleted the od/unsupported-syntax branch May 26, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Possibly missing diagnostics for vector of vector of variables
1 participant