Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] split user-defined Hessian tutorial in two #3274

Merged
merged 5 commits into from
Mar 9, 2023

Conversation

jd-foster
Copy link
Collaborator

Removed the Rosenbrock example (it's covered in the manual section) to get to the bilevel optimization as the meat of the tutorial, which is not in the title too. What do you think?

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (63f92c2) 98.10% compared to head (595ca0d) 98.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3274   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files          34       34           
  Lines        4704     4704           
=======================================
  Hits         4615     4615           
  Misses         89       89           
Impacted Files Coverage Δ
src/sd.jl 100.00% <0.00%> (ø)
src/nlp.jl 100.00% <0.00%> (ø)
src/JuMP.jl 96.87% <0.00%> (ø)
src/macros.jl 98.57% <0.00%> (ø)
src/shapes.jl 100.00% <0.00%> (ø)
src/aff_expr.jl 97.28% <0.00%> (ø)
src/objective.jl 96.66% <0.00%> (ø)
src/quad_expr.jl 100.00% <0.00%> (ø)
src/constraints.jl 96.51% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow
Copy link
Member

odow commented Mar 8, 2023

If I recall correctly, I think @ccoffrin and I discussed that having a simple example to start had benefits. Perhaps we could just split in two?

@odow
Copy link
Member

odow commented Mar 8, 2023

Perhaps let's leave the user-defined hessians as just Rosenbrock, and make "Nested optimization" a separate tutorial?

@jd-foster
Copy link
Collaborator Author

Ok, I'll split it in two.

@odow odow changed the title Edit to highlight bilevel opt. [docs] split user-defined Hessian tutorial in two Mar 8, 2023
@odow odow merged commit b5e50a3 into jump-dev:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants