Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] fix thread safefy issue in parallelism tutorial #3240

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Conversation

odow
Copy link
Member

@odow odow commented Feb 26, 2023

As pointed out on Discourse, https://discourse.julialang.org/t/jump-multi-threading-example/95210/2, I didn't check carefully enough and I assumed that push! was an atomic operation in Julia.

@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Base: 98.07% // Head: 98.08% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c69b2a5) compared to base (385c72f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3240   +/-   ##
=======================================
  Coverage   98.07%   98.08%           
=======================================
  Files          34       34           
  Lines        4632     4656   +24     
=======================================
+ Hits         4543     4567   +24     
  Misses         89       89           
Impacted Files Coverage Δ
src/JuMP.jl 96.82% <ø> (ø)
src/optimizer_interface.jl 96.33% <100.00%> (+0.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ericphanson
Copy link
Contributor

I don’t think this is safe either, xref JuliaLang/julia#48542

@odow
Copy link
Member Author

odow commented Feb 26, 2023

Urgh. Okay. I've updated to use a lock, which is what I probably should have used right from the start.

@odow odow merged commit 2b93d2b into master Feb 27, 2023
@odow odow deleted the od/parallelism branch February 27, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants