Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JuMP.jl, moving methods into their related files #3188

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Conversation

odow
Copy link
Member

@odow odow commented Jan 12, 2023

The diff is fairly large, but this has always annoyed me: The previous content of JuMP.jl was confusing. It wasn't ordered, and it contained a mix of methods that are better off living in other files.

For example, why was index(cr::ConstraintRef) in JuMP.jl, but index(v::VariableRef) in variables.jl?

There were also things like result_count(model) was in optimizer_interface.jl, but termination_status(model) was in JuMP.jl.

The previous content of JuMP.jl was confusing. It wasn't ordered,
and it contained a mix of methods that are better off living in
other files.
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 98.06% // Head: 98.06% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (cba5104) compared to base (67ed280).
Patch coverage: 95.37% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3188      +/-   ##
==========================================
- Coverage   98.06%   98.06%   -0.01%     
==========================================
  Files          33       33              
  Lines        4592     4590       -2     
==========================================
- Hits         4503     4501       -2     
  Misses         89       89              
Impacted Files Coverage Δ
src/mutable_arithmetics.jl 88.34% <ø> (ø)
src/operators.jl 96.31% <83.33%> (-0.33%) ⬇️
src/JuMP.jl 96.77% <91.66%> (+0.66%) ⬆️
src/optimizer_interface.jl 95.87% <95.91%> (-0.21%) ⬇️
src/constraints.jl 96.51% <100.00%> (+0.01%) ⬆️
src/variables.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, there were many things in JuMP.jl that should have been at other places

@odow odow merged commit a978323 into master Jan 17, 2023
@odow odow deleted the od/tidy-jump branch January 17, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants