Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy import of packages and remove unnecessary prefixes #3186

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

odow
Copy link
Member

@odow odow commented Jan 11, 2023

Our imports and prefixes were scattered throughout the source and often conflicted (both using LinearAlgebra and import LinearAlgebra, and some calls prefixed and some calls not).

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 98.05% // Head: 98.06% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (bf070db) compared to base (e4b0610).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3186   +/-   ##
=======================================
  Coverage   98.05%   98.06%           
=======================================
  Files          33       33           
  Lines        4587     4591    +4     
=======================================
+ Hits         4498     4502    +4     
  Misses         89       89           
Impacted Files Coverage Δ
src/Containers/Containers.jl 91.66% <ø> (ø)
src/Containers/macro.jl 100.00% <ø> (ø)
src/feasibility_checker.jl 100.00% <ø> (ø)
src/lp_sensitivity2.jl 97.76% <ø> (ø)
src/solution_summary.jl 97.50% <ø> (ø)
src/JuMP.jl 96.09% <100.00%> (ø)
src/aff_expr.jl 97.25% <100.00%> (ø)
src/constraints.jl 96.49% <100.00%> (ø)
src/copy.jl 96.15% <100.00%> (ø)
src/macros.jl 98.51% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow odow merged commit cfc32ce into master Jan 11, 2023
@odow odow deleted the od/prefix branch January 11, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant