Improve error message for common case of using Bool instead of Bin #3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was motivated by the discourse post: https://discourse.julialang.org/t/how-to-declare-a-boolean-variable/41279 It is one of the top-10 most read posts on the JuMP section of the discourse forum, so it is obviously a common stumbling block, particularly because we support Int for integer variables.
Codecov ReportBase: 98.07% // Head: 98.07% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3181 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 33 33
Lines 4563 4567 +4
=======================================
+ Hits 4475 4479 +4
Misses 88 88
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This is definitely a JuMP 2.0 consideration. It's weird that we have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was motivated by the discourse post:
https://discourse.julialang.org/t/how-to-declare-a-boolean-variable/41279
It is one of the top-10 most read posts on the JuMP section of the discourse forum, so it is obviously a common stumbling block, particularly because we support Int for integer variables.