Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test/Containers into functional form #3158

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Conversation

odow
Copy link
Member

@odow odow commented Dec 20, 2022

No description provided.

@odow
Copy link
Member Author

odow commented Dec 20, 2022

These test failures are precisely the reason to refactor the tests. Changing the scope of files in test/Containers breaks an unrelated test in test/containers.jl (because test/Containers no longer includes a global using JuMP statement).

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 97.69% // Head: 97.69% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (82ba59e) compared to base (8f6081b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3158   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files          33       33           
  Lines        4470     4472    +2     
=======================================
+ Hits         4367     4369    +2     
  Misses        103      103           
Impacted Files Coverage Δ
src/JuMP.jl 95.83% <0.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow odow merged commit 34462e4 into master Dec 20, 2022
@odow odow deleted the od/container-function-tests branch December 20, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant