Add support for creation of complex variables #3134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 97.68% // Head: 97.68% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3134 +/- ##
=======================================
Coverage 97.68% 97.68%
=======================================
Files 33 33
Lines 4442 4454 +12
=======================================
+ Hits 4339 4351 +12
Misses 103 103
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
odow
approved these changes
Nov 23, 2022
|
Merge, and then work on some comprehensive docs for |
odow
force-pushed
the
bl/complex_variable
branch
from
e3f8550
to
51d0078
Compare
|
Yes, we still needs docs but also PSD constraints in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to create complex variables. The main point of arguments were discussed part of #3109 so this PR should be more straightforward.